parser: if closing square bracket not found, stop looking for it again#6036
Merged
sylvestre merged 1 commit intouutils:mainfrom Mar 11, 2024
Merged
parser: if closing square bracket not found, stop looking for it again#6036sylvestre merged 1 commit intouutils:mainfrom
sylvestre merged 1 commit intouutils:mainfrom
Conversation
Contributor
|
and could you please add a test ? |
Collaborator
|
It's mostly a performance fix if I understand correctly, so what kind of test would you like to have? |
Contributor
|
oh, it will be obvious when it will fail: take forever :) |
Collaborator
|
Fair 😄 |
Contributor
|
@cj-zoltan-kiss ping? |
cj-zoltan-kiss
force-pushed
the
zoltankiss/globfix
branch
from
4c1e167 to
4fc3a1b
Compare
Contributor
Author
|
Sorry, I was on holiday last week, I've updated the PR |
|
GNU testsuite comparison: |
This solves uutils#5584, where the fuzzing would take hours without this.
cj-zoltan-kiss
force-pushed
the
zoltankiss/globfix
branch
from
4fc3a1b to
be24742
Compare
|
GNU testsuite comparison: |
Contributor
|
Many thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves #5584, where the fuzzing would take hours without this.