Merged
Conversation
Contributor
|
hi @matrixhead . it seems that we are both working on |
Contributor
Author
|
@cre4ture sorry my bad i should've done that, i will try to do that from now on also since you were working on this issue could you give me your thoughts on this pr. |
Contributor
|
Don't worry. I'm working on |
cakebaker
reviewed
Mar 17, 2024
cakebaker
reviewed
Mar 17, 2024
|
GNU testsuite comparison: |
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Contributor
|
Thanks for your PR and great to see that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes the
misctest case in dd, it was failing because there was this check in misc where dd should error when given the input via stdin is not a folder andiflag=directoryis set.