Skip to content

csplit: remove crate_name attribute#6091

Merged
sylvestre merged 1 commit intouutils:mainfrom
cakebaker:csplit_remove_crate_name_attribute
Mar 18, 2024
Merged

csplit: remove crate_name attribute#6091
sylvestre merged 1 commit intouutils:mainfrom
cakebaker:csplit_remove_crate_name_attribute

Conversation

@cakebaker
Copy link
Contributor

While reviewing #6090 I noticed a crate_name attribute I think is unnecessary as no other util uses it. According to https://doc.rust-lang.org/rust-by-example/attribute/crate.html:

it is important to note that both the crate_type and crate_name attributes have no effect whatsoever when using Cargo, the Rust package manager.

@sylvestre sylvestre merged commit 7819cb3 into uutils:main Mar 18, 2024
@sylvestre
Copy link
Contributor

TIL

@cakebaker cakebaker deleted the csplit_remove_crate_name_attribute branch March 18, 2024 09:27
@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/dd/misc. tests/dd/misc is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/csplit/csplit is no longer failing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants