fmt: use get_matches_from() instead of try_get_matches_from() in tests#6374
Merged
BenWiederhake merged 1 commit intouutils:mainfrom May 7, 2024
Merged
Conversation
|
GNU testsuite comparison: |
Collaborator
|
Yes, the code is much easier to read. However, when an unexpected failure occurs, this now kills the entire test suite due to the direct invocation of Suggestion: Mostly your approach, but with |
e40bd02 to
3558dd3
Compare
Contributor
Author
|
Changes since last push:
|
|
GNU testsuite comparison: |
BenWiederhake
approved these changes
May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing #6362 I noticed that we use
try_get_matches_from()in the tests. We pass only valid values to this function, and so it's simpler to useget_matches_from().