cp: Added overwrite detection for existing symlinks#6380
cp: Added overwrite detection for existing symlinks#6380BenWiederhake merged 4 commits intouutils:mainfrom
cp: Added overwrite detection for existing symlinks#6380Conversation
cp: Added overwrite detection for existing symlinks
There was a problem hiding this comment.
Thanks for tackling this issue!
By slightly changing the test setup, you (accidentally?) created another interesting test case, please keep it! :D
EDIT: Regarding the clippy failure: I'm afraid the sheer amount of "state" that is passed between the various copy-functions means that this really should be changed to a struct, perhaps?
|
GNU testsuite comparison: |
|
The state can be refactored and encapsulated within a struct . Perhaps that can be addressed in a future PR . |
|
GNU testsuite comparison: |
1 similar comment
|
GNU testsuite comparison: |
4049b2a to
f9bcef7
Compare
BenWiederhake
left a comment
There was a problem hiding this comment.
Mostly just questions, there's probably not much to do anymore.
Also, can I convince you to remove #[allow(clippy::too_many_arguments)] in your next PR?
BenWiederhake
left a comment
There was a problem hiding this comment.
LGTM! We're still bad at handling symlinks, but this is a step in the right direction. Yay! :)
Fixes #6265