touch: change message when directory#6506
Merged
sylvestre merged 1 commit intouutils:mainfrom Jun 30, 2024
Merged
Conversation
Contributor
|
Please add a test to make sure we don't regress |
Contributor
Author
|
Yes you're right Now the code is also cleaner I think |
Contributor
|
the initial commit message isn't ideal btw |
Contributor
Author
|
Can you just squash all commits ? (when merging) Or I can squash them if needed :) |
Contributor
|
sure but it is still appreciated to have valid commit message. esp as github uses the first as input :) |
Its-Just-Nans
force-pushed
the
touch-directory
branch
from
e9285bb to
2c1f6fe
Compare
Contributor
Author
|
my bad Is-it correct now ? |
sylvestre
reviewed
Jun 29, 2024
sylvestre
reviewed
Jun 29, 2024
Its-Just-Nans
force-pushed
the
touch-directory
branch
from
03d552f to
412e51b
Compare
Its-Just-Nans
force-pushed
the
touch-directory
branch
from
412e51b to
635ad16
Compare
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #2639