uptime: relax error message due to different errno on MacOS#6571
Merged
sylvestre merged 1 commit intouutils:mainfrom Jul 15, 2024
Merged
uptime: relax error message due to different errno on MacOS#6571sylvestre merged 1 commit intouutils:mainfrom
sylvestre merged 1 commit intouutils:mainfrom
Conversation
Contributor
|
thanks |
Collaborator
Author
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6569 by relaxing the test. Apparently, the entire stderr generated on MacOS is merely
uptime: couldn't get boot time\n. It is unclear to my whyuptime: couldn't get boot time: Illegal seekwas expected, but this still seems like good behavior to me, so let's make the test green.My best guess is that the error message changed slightly in #6514, but that PR had a green test. I don't understand.