cksum: accept non-UTF-8 filenames#6575
Merged
cakebaker merged 3 commits intouutils:mainfrom Jul 30, 2024
Merged
Conversation
af3e60c to
24c8b99
Compare
Collaborator
Author
|
CI failures are unrelated issues:
|
ed05338 to
5b82c63
Compare
Collaborator
Author
|
Changes since initial push:
|
415c1f7 to
3c949a7
Compare
Collaborator
Author
|
Changes since last push description:
|
26957a3 to
a3efe5b
Compare
Collaborator
Author
|
Changes since last push description:
Remaining CI failures are unrelated:
|
66112fb to
3d5232b
Compare
Collaborator
Author
|
Changes since last push description:
|
cakebaker
reviewed
Jul 23, 2024
cakebaker
reviewed
Jul 23, 2024
src/uu/cksum/src/cksum.rs
Outdated
| "{} {}", | ||
| sum.parse::<u16>().unwrap(), | ||
| div_ceil(sz, options.output_bits) | ||
| let (before_filename, print_filename, after_filename) = match (options.algo_name, not_file) |
Contributor
There was a problem hiding this comment.
The print_filename var name is a bit misleading and I was surprised it's of type bool. I expected it to be a String, like the other two vars. My suggestion is to rename it to something like should_print_filename.
cakebaker
reviewed
Jul 23, 2024
3d5232b to
4c9cd6e
Compare
|
GNU testsuite comparison: |
4c9cd6e to
0119cc1
Compare
Collaborator
Author
|
Changes since (my?) last push:
|
0119cc1 to
1fcff25
Compare
Collaborator
Author
|
Changes since last push:
|
Contributor
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6574.
Example: