Conversation
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Luv-Ray
force-pushed
the
cksum_error_handling
branch
from
5ea3b8a to
c9776e7
Compare
| .stderr_contains("WARNING: 1 line is improperly formatted"); | ||
| } | ||
|
|
||
| #[cfg(not(windows))] |
There was a problem hiding this comment.
https://github.com/uutils/coreutils/actions/runs/11424022765/job/31783927716#step:7:3602
seems that windows has a different logic and is guarded by another test
coreutils/tests/by-util/test_cksum.rs
Lines 1195 to 1198 in 9a6f552
There was a problem hiding this comment.
could you please document this into the test ?
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
RenjiSann
left a comment
RenjiSann
left a comment
There was a problem hiding this comment.
Please fixup the second and third commits into the first one, for better readability after merge.
Other than that, LGTM 👍
| // if any incorrectly formatted line, show it | ||
| cksum_output(&res, status); | ||
|
|
There was a problem hiding this comment.
Is there a specific reason for moving this up ?
There was a problem hiding this comment.
As shown in the code snippet in #6796 :
$ ../../../gnu/src/cksum -c CHECKSUM --ignore-missing
../../../gnu/src/cksum: dir: Is a directory
dir: FAILED open or read
../../../gnu/src/cksum: WARNING: 1 listed file could not be read
../../../gnu/src/cksum: CHECKSUM: no file was verified
warnings in cksum_output show up first, and CHECKSUM: no file was verified shows up later.
tests/by-util/test_cksum.rs
Outdated
| /// Windows has a different logic and is guarded by [`test_check_directory_error`]. | ||
| #[cfg(not(windows))] | ||
| #[test] | ||
| fn test_check_error_handling() { |
There was a problem hiding this comment.
I'd rename this test_check_failed_to_read, to be a bit more specific.
Luv-Ray
force-pushed
the
cksum_error_handling
branch
from
47a28ed to
d5cc3dd
Compare
|
Thanks @Luv-Ray and @RenjiSann ! |
4 participants
fixes #6796