Closed
Conversation
cakebaker
force-pushed
the
ci_remove_zprofile
branch
from
9ceb57b to
4993b96
Compare
|
GNU testsuite comparison: |
Merged
Collaborator
|
Code coverage tests seem to fail for other reasons, can this PR be merged ? @cakebaker @sylvestre |
Contributor
Author
|
I think the code coverage tests fail because of this PR even though they fail with three different errors now :| |
cakebaker
force-pushed
the
ci_remove_zprofile
branch
from
4993b96 to
615b707
Compare
|
GNU testsuite comparison: |
cakebaker
force-pushed
the
ci_remove_zprofile
branch
from
615b707 to
eccb5da
Compare
|
GNU testsuite comparison: |
cakebaker
force-pushed
the
ci_remove_zprofile
branch
from
eccb5da to
a5434d8
Compare
|
GNU testsuite comparison: |
Collaborator
My bad, I wanted to comment on #6822 , not here 😔 |
sylvestre
reviewed
Nov 12, 2024
.github/workflows/CICD.yml
Outdated
| env: | ||
| RUSTC_WRAPPER: "" | ||
| RUSTFLAGS: "-Zprofile -Ccodegen-units=1 -Copt-level=0 -Clink-dead-code -Coverflow-checks=off -Zpanic_abort_tests -Cpanic=abort" | ||
| RUSTFLAGS: "-Cprofile-generate=target/debug -Ccodegen-units=1 -Copt-level=0 -Clink-dead-code -Coverflow-checks=off -Zpanic_abort_tests -Cpanic=abort" |
Contributor
There was a problem hiding this comment.
Suggested change
| RUSTFLAGS: "-Cprofile-generate=target/debug -Ccodegen-units=1 -Copt-level=0 -Clink-dead-code -Coverflow-checks=off -Zpanic_abort_tests -Cpanic=abort" | |
| RUSTFLAGS: "-Cprofile-generate=${{ vars.RUNNER_TEMP }}/target/debug -Ccodegen-units=1 -Copt-level=0 -Clink-dead-code -Coverflow-checks=off -Zpanic_abort_tests -Cpanic=abort" |
cakebaker
force-pushed
the
ci_remove_zprofile
branch
from
a5434d8 to
e2e699e
Compare
|
GNU testsuite comparison: |
cakebaker
force-pushed
the
ci_remove_zprofile
branch
from
e2e699e to
6e83cd6
Compare
|
GNU testsuite comparison: |
cakebaker
force-pushed
the
ci_remove_zprofile
branch
9 times, most recently
from
37c41f8 to
c13cc2e
Compare
Support for -Zprofile has been removed in rust-lang/rust#131829
cakebaker
force-pushed
the
ci_remove_zprofile
branch
2 times, most recently
from
89d75ce to
748467a
Compare
cakebaker
force-pushed
the
ci_remove_zprofile
branch
from
748467a to
397387e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code coverage jobs currently fail with the following error:
The reason is that the support for
-Zprofilehas been removed in rust-lang/rust#131829This PR removes
-Zprofile, though probably more work is necessary.