Skip to content

sort: enable clippy::suspicious_open_options on OpenBSD#6851

Merged
sylvestre merged 1 commit into
uutils:mainfrom
lcheylus:openbsd-suspicious_open_options
Nov 14, 2024
Merged

sort: enable clippy::suspicious_open_options on OpenBSD#6851
sylvestre merged 1 commit into
uutils:mainfrom
lcheylus:openbsd-suspicious_open_options

Conversation

@lcheylus
Copy link
Copy Markdown
Contributor

On OpenBSD 7.6 (release October 2024), Rust version = 1.81.0 => we can now enable clippy::suspicious_open_options for lint with clippy.

Revert commit ee4392e


Tests OK with clippy (Rust 1.81 on OpenBSD 7.6) for sort:

$ cargo clippy --all-targets -puu_sort -- -W clippy::manual_string_new -D warnings
(...)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.61s

On OpenBSD 7.6 (release October 2024), Rust version = 1.81.0 => we can now enable
clippy::suspicious_open_options.

Revert commit ee4392e

Signed-off-by: Laurent Cheylus <foxy@free.fr>
@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/rm/rm1 (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre merged commit 17fee51 into uutils:main Nov 14, 2024
@lcheylus lcheylus deleted the openbsd-suspicious_open_options branch November 14, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants