fix(seq): handle 0e... scientific notation without padding#6934
Merged
cakebaker merged 3 commits intouutils:mainfrom Dec 7, 2024
karanabe:bugfix/seq-scientific-zero-padding
Merged
fix(seq): handle 0e... scientific notation without padding#6934cakebaker merged 3 commits intouutils:mainfrom karanabe:bugfix/seq-scientific-zero-padding
cakebaker merged 3 commits intouutils:mainfrom
karanabe:bugfix/seq-scientific-zero-padding
Conversation
|
GNU testsuite comparison: |
- Updated the parse_exponent_no_decimal function to treat 0e... as zero. - Added test cases to verify correct behavior for 0e15 and -w 0e15. Fix: #6926
|
GNU testsuite comparison: |
Contributor
|
I don't know if you have seen it: the changes break |
Contributor
Author
|
Sorry. I was looking at the integration test, but I must have missed the unit test. I fixed it. |
Contributor
No problem :) Can you please run |
Contributor
Author
|
Thank you for the attention. I seem to have gotten impatient, I didn't follow the DEVELOPMENT.md procedure. |
|
GNU testsuite comparison: |
Contributor
|
Thanks for your PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #6926
This pull request fixes the issue where
seqmishandles scientific notation in the form of0e...by treating it as zero.Note;
While testing with
bash util/run-gnu-test.sh, I discovered another bug unrelated to this fix. I will file a new issue.cargo run -q seq 0x1p-1 2 seq: invalid hexadecimal argument: '0x1p-1'