chroot: handle the error when invalid user#7015
Merged
cakebaker merged 1 commit intouutils:mainfrom Dec 31, 2024
sylvestre:chroot-user
Merged
chroot: handle the error when invalid user#7015cakebaker merged 1 commit intouutils:mainfrom sylvestre:chroot-user
cakebaker merged 1 commit intouutils:mainfrom
sylvestre:chroot-user
Conversation
Currently fails with:
```
2024-12-28T14:55:18.9330231Z thread 'main' panicked at src/uu/chroot/src/chroot.rs:284:46:
2024-12-28T14:55:18.9330718Z called `Result::unwrap()` on an `Err` value: Custom { kind: NotFound, error: "Not found: nobody:+65535" }
2024-12-28T14:55:18.9331305Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
```
|
GNU testsuite comparison: |
Contributor
Author
|
Does not fix the issue but not a rust panic anymore: |
cakebaker
reviewed
Dec 30, 2024
| if let Ok(result) = run_ucmd_as_root(&ts, &["--user=nobody:+65535", dir, "pwd"]) { | ||
| result | ||
| .failure() | ||
| .stderr_contains("no such user: nobody:+65535"); |
Contributor
There was a problem hiding this comment.
Is the error message deliberately different from the one of GNU chroot?
Contributor
Author
There was a problem hiding this comment.
yeah, it is for a next step
I am just removing the panic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently fails with: