publish.sh: be more prescriptive on the grep#7983
Merged
Conversation
otherwise, we are getting version.workspace first
|
GNU testsuite comparison: |
cakebaker
reviewed
May 25, 2025
Contributor
cakebaker
left a comment
cakebaker
left a comment
There was a problem hiding this comment.
Looks good. An alternative would be to move the workspace.package section to the top of Cargo.toml instead.
There is an unknown word in the commit message (and PR title): prescrive. Did you mean "precise"?
Contributor
Author
|
it meant "prescriptive" sorry! |
cakebaker
changed the title
sylvestre
added a commit
to sylvestre/coreutils
that referenced
this pull request
Jun 2, 2025
otherwise, we are getting version.workspace first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
otherwise, we are getting version.workspace first