Skip to content

deny.toml: remove obsolete skips related to rustix#8019

Merged
sylvestre merged 1 commit intouutils:mainfrom
alerque:cleanup-deny
May 29, 2025
Merged

deny.toml: remove obsolete skips related to rustix#8019
sylvestre merged 1 commit intouutils:mainfrom
alerque:cleanup-deny

Conversation

@alerque
Copy link
Contributor

@alerque alerque commented May 28, 2025

The holdup on crossterm was bumped in d5258d2, bringing rustix to 0.38.44. Meanwhile while
linux-raw-sys is still at 0.4.15 in the lock file, it is unclear to my why it got added in 2c0f97f
in the first place as it does not seem to trigger any complaints from cargo deny.

The holdup on crossterm was bumped in d5258d2, bringing rustix to 0.38.44. Meanwhile while
linux-raw-sys is still at 0.4.15 in the lock file, it is unclear to my why it got added in 2c0f97f
in the first place as it does not seem to trigger any complaints from `cargo deny`.
@alerque
Copy link
Contributor Author

alerque commented May 28, 2025

Perhaps @cakebaker can remember why this was added, perhaps it was to cover something transient in dependencies of linux-raw-sys that have themselves since been bumped or a feature that is no longer used? That rustix is now bumped an this exclusion is obsolete makes sense, but I don't understand why linux-raw-sys is no longer triggering any complaints from cargo-deny if it ever was.

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@cakebaker
Copy link
Contributor

Somehow I don't understand why these two entries can be removed as we still have two versions of them in Cargo.lock :|

@sylvestre sylvestre merged commit 7e293a3 into uutils:main May 29, 2025
74 checks passed
@alerque
Copy link
Contributor Author

alerque commented May 29, 2025

@cakebaker I agree, something is fishy. There are several things listed that don't make sense and some that are not that would seem to. It might have something to do with direct vs. transitive dependencies, but I can't make out what the rules actually are.

@cakebaker
Copy link
Contributor

@alerque my guess is that it's because the "old" rustix version is only used by a platform-specific dev dependency and thus doesn't show up in the dependency graph constructed by cargo deny. Anyway, I created a PR to get rid of this dependency.

@alerque
Copy link
Contributor Author

alerque commented May 31, 2025

@cakebaker Does that mean there is a bug in cargo deny in that it isn't traversing everything it should, or should this project's CI include some extra runs that explicitly target platforms that are not currently getting checked?

@alerque alerque deleted the cleanup-deny branch May 31, 2025 07:57
@cakebaker
Copy link
Contributor

@alerque it's difficult for me to say whether it's a bug or some configuration issue on our side :|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants