GNUmakefile: Use any profile from make install

[oech3]

Allow to use any profile at make e.g. make install PROFILE=release-fast.

[sylvestre]

Could you please add a check in the ci to make sure we don't regress in the future, thanks

[oech3]

No idea about what should I test. Everything are installed at same place for each PROFILE...

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/tail/overlay-headers is no longer failing!

[codspeed-hq]

CodSpeed Performance Report

Merging #8730 will not alter performance

_{Comparing oech3:profile (b933a01) with main (799bea0)}

Summary

✅ 123 untouched
⏩ 5 skipped¹

Footnotes

1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[sylvestre]

something like this:
https://github.com/uutils/coreutils/blob/main/.github/workflows/CICD.yml#L474-L479
and verify that a few files exist

[oech3]

Included PROFILE=release-fast to one of a test and added test -f check.

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

[sylvestre]

it regressed a freebsd test:

 cargo build --features feat_external_libstdbuf --features "arch base32 base64 basename basenc cat chgrp chmod chown chroot cksum comm cp csplit cut date dd df dir dircolors dirname du echo env expand expr factor false fmt fold groups hashsum head hostid hostname id install join kill link ln logname ls mkdir mkfifo mknod mktemp more mv nice nl nohup nproc numfmt od paste pathchk pinky pr printenv printf ptx pwd readlink realpath rm rmdir seq shred shuf sleep sort split stat stdbuf stty sum sync tac tail tee test timeout touch tr true truncate tsort tty uname unexpand uniq unlink uptime users vdir wc who whoami yes " --profile=ci --no-default-features
  error: profile `ci` is not defined
  gmake[1]: Leaving directory '/home/runner/work/coreutils/coreutils'
  gmake[1]: *** [GNUmakefile:341: build-coreutils] Error 101

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

[oech3]

FreeBSD test started with make mextest PROFILE=ci. but many not found err e.g. stdbuf: External libstdbuf not found at configured path: /usr/local/libexec/coreutils/libstdbuf.so.

@Ecordonnier Is the file path hardcoded in tests? Is the any idea for it?

[Ecordonnier]

stdbuf: External libstdbuf not found at configured path: /usr/local/libexec/coreutils/libstdbuf.so

@Ecordonnier Is the file path hardcoded in tests? Is the any idea for it?

Yes this path is where the file gets installed per default when running make install.

[Ecordonnier]

stdbuf: External libstdbuf not found at configured path: /usr/local/libexec/coreutils/libstdbuf.so

@Ecordonnier Is the file path hardcoded in tests? Is the any idea for it?

See #8684 (comment)

[oech3]

Thankyou for noting about #8684 (comment) .
So is the failing test at here should be pass after the comment impremented and nothing to fix at this PR?

[Ecordonnier]

Thankyou for noting about #8684 (comment) .
So is the failing test at here should be pass after the comment impremented and nothing to fix at this PR?

Yes

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

[oech3]

@Ecordonnier Can we force-enable libstdbuf test by sudo?

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/rm/rm1 (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

[Ecordonnier]

@Ecordonnier Can we force-enable libstdbuf test by sudo?

What do you mean?

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

[oech3]

4.0.0 was released before fixing this. Cannnot fetch binary from distribution's repo yet...

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

[sylvestre]

Cannnot fetch binary from distribution's repo yet...

sorry but what does it mean ? :)

[oech3]

Linux distribution depending on make cannot distribute binary with PROFILE=release-fast without patching.

[oech3]

Still difficult to merge this?

[sylvestre]

Still difficult to merge this?

what do you mean?

Linux distribution depending on make cannot distribute binary with PROFILE=release-fast without patching.

this is fine, no ?

[oech3]

No. Because it is difficult to install smaller binary with manpages, completions, etc... manually. Please do not hardcode release profile.

[sylvestre]

distro packagers can always patches the sources ;)

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

[oech3]

Yes. But tracing upstream's change is difficult. Please avoid hardcoding . The fact that make install PROFILE=release-small installs binary with PROFILE=release is difficult to understand.

[sylvestre]

yeah, you have been clear, don't worry!

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

[github-actions]

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

[oech3]

Meaning of diff caused by this PR is clear now (by separating PRs).

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

[oech3]

Thankyou! I and Ubuntu can drop a patch now.