Merged
Conversation
Collaborator
多加 attribute 是好的，只是烦请给出辅助判断的依据，这样 reviewer 才可以确定你加的 attribute 是对的。 |
rootmelo92118
approved these changes
Dec 15, 2025
github-actions bot
added a commit
to YW5vbnltb3Vz/domain-list-community
that referenced
this pull request
Dec 15, 2025
* https://github.com/v2fly/domain-list-community: Add Ookla Speedtest Central to the list (v2fly#3053) Update 18comic & picacg (v2fly#2695) Chore: bump actions/upload-artifact from 5 to 6 (v2fly#3051)
Contributor
这段会导致某些软件（如dae）报错，希望能 revert。 或者加到单独的文件里，不要加到 geosite:geolocation-!cn 这个被广泛使用的分类里。 |
Contributor
|
初步判断应该是 |
是的，look ahead 不被 Golang 支持，不符合本项目 https://github.com/v2fly/domain-list-community/blob/master/README.md 中对于语法的要求 |
This was referenced Dec 16, 2025
9 tasks
|
一条干崩多少客户端😂 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2687
Sorry about that—I thought adding more attributes would be helpful (I even recall an old issue encouraging detailed attributes). I’ve just pushed a new PR—would love any feedback!
很抱歉，我以為這樣多加 attribute 是好的，我印象裡多年前也有 Issues 鼓勵詳加 attribute 。
現已提出新的 PR ，還望斧正。