fix: reset freeze pane split positions when switching sheets#9035
Open
DiegoCardoso wants to merge 1 commit intomainfrom
Open
fix: reset freeze pane split positions when switching sheets#9035DiegoCardoso wants to merge 1 commit intomainfrom
DiegoCardoso wants to merge 1 commit intomainfrom
Conversation
When switching between sheets, freeze pane split positions from the previous sheet could bleed into the next sheet. This happened because the else branches only handled scroll restoration but never explicitly reset split positions to 0 when a sheet had no split in one direction. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setHorizontalSplitPosition/setVerticalSplitPositionbehind split-exists checks but theelsebranches never explicitly reset the positions to 0Fixes #9006
Test plan
SpreadsheetFactoryTestverify all freeze pane combinations (both splits, only rows, only columns, none) and the sheet-switching bleed scenarioHiddenAndFrozenIT,LoadFileWithFrozenPaneScrolledIT,MergedCellFrozenIT) all pass🤖 Generated with Claude Code