feat: add support for slotted header and footer content#10624
Merged
web-padawan merged 11 commits intomainfrom Feb 4, 2026
Merged
feat: add support for slotted header and footer content#10624web-padawan merged 11 commits intomainfrom
web-padawan merged 11 commits intomainfrom
Conversation
|
Implements dynamic slot detection for header-content and footer slots, enabling users to pass content directly via slots instead of only through renderers. Key changes: - Add SlotObserver to monitor header-content and footer slots - Dynamically set has-header/has-footer attributes based on both renderers AND slotted content presence - Smart content detection that ignores empty elements and renderer-created containers - Support for mixed usage (renderers + slots simultaneously) Tests: - Add 17 new unit tests for slotted content scenarios - Add 8 visual regression tests - All existing tests continue to pass (196 total) Fixes #10339 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
sissbruecker
force-pushed
the
feat/dialog-slotted-header-footer
branch
from
bad6874 to
bfea625
Compare
web-padawan
reviewed
Feb 3, 2026
|
web-padawan
approved these changes
Feb 4, 2026
Collaborator
|
This ticket/PR has been released with Vaadin 25.1.0-alpha8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for slotted header and footer content, in addition to using renderers.
Fixes #10339
Type of change