Skip to content

fix: do not dispatch backdrop click when mousedown is in details#10711

Merged
web-padawan merged 1 commit intomainfrom
fix/mdl-backdrop-click
Dec 18, 2025
Merged

fix: do not dispatch backdrop click when mousedown is in details#10711
web-padawan merged 1 commit intomainfrom
fix/mdl-backdrop-click

Conversation

@sissbruecker
Copy link
Contributor

Description

#9665 introduced a regression where mousedown on the details content and mouseup on the internal details wrapper can result in a click and thus a backdrop-click event. This is because the internal details wrapper is a common ancestor for both mousedown and mouseup.

This change removes pointer events on the details wrapper and restores them on the details content, which allows clicking the actual backdrop.

Fixes #10702

Type of change

  • Bugfix

@sonarqubecloud
Copy link

@web-padawan web-padawan removed the request for review from jouni December 18, 2025 09:59
@web-padawan web-padawan merged commit 1ec92b0 into main Dec 18, 2025
9 checks passed
@web-padawan web-padawan deleted the fix/mdl-backdrop-click branch December 18, 2025 09:59
@vaadin-bot
Copy link
Collaborator

Hi @sissbruecker and @web-padawan, when i performed cherry-pick to this commit to 24.9, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 1ec92b0
error: could not apply 1ec92b0... fix: do not dispatch backdrop click when mousedown is in details (#10711)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 25.1.0-alpha1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MasterDetailLayout backdropClickListener bug

3 participants