feat: implement slider and range-slider pointer events support#10966

Merged

web-padawan merged 19 commits intomainfrom

feat/slider-pointer-events

Jan 16, 2026

Member

web-padawan commented Jan 15, 2026 •

edited

Loading

Description

Part of #10948

Added pointerdown, pointermove and pointerup listeners to modify slider and range slider value.

Type of change

Feature

Note

Range slider pointer test skipped in Firefox as there are some issues with sendMouse there, see also:

web-components/packages/dashboard/test/dashboard-widget-reordering.test.ts

Lines 140 to 141 in 54626c7

    
           // The sendMouse helper does not seem to work well with Firefox 
        
           (isFirefox ? it.skip : it)('should reorder using native DnD', async () => {

web-padawan requested a review from vursen

January 15, 2026 08:32

vursen reviewed

View reviewed changes

packages/slider/src/vaadin-slider-mixin.js Outdated Show resolved Hide resolved

vursen reviewed

View reviewed changes

packages/slider/src/vaadin-range-slider.js Outdated Show resolved Hide resolved

web-padawan force-pushed the feat/slider-pointer-events branch from a55fa0d to e9f0545 Compare

January 15, 2026 08:38

vursen reviewed

View reviewed changes

packages/slider/src/vaadin-slider-mixin.js Show resolved Hide resolved

packages/slider/src/vaadin-slider-mixin.js Outdated Show resolved Hide resolved

packages/slider/src/vaadin-slider-mixin.js Outdated Show resolved Hide resolved

web-padawan force-pushed the feat/slider-pointer-events branch from e9f0545 to d0a7498 Compare

January 15, 2026 08:57

vursen reviewed

View reviewed changes

packages/slider/src/vaadin-slider-mixin.js Outdated Show resolved Hide resolved

web-padawan force-pushed the feat/slider-pointer-events branch 2 times, most recently from 1331694 to 8e6aec8 Compare

January 15, 2026 09:34

vursen reviewed

View reviewed changes

packages/slider/test/range-slider.test.ts Outdated Show resolved Hide resolved

vursen reviewed

View reviewed changes

packages/slider/src/vaadin-range-slider.js Show resolved Hide resolved

vursen reviewed

View reviewed changes

packages/slider/test/slider.test.ts Outdated Show resolved Hide resolved

web-padawan force-pushed the feat/slider-pointer-events branch from 02b71e3 to cef1653 Compare

January 15, 2026 14:46

web-padawan and others added 16 commits

January 16, 2026 09:42


          feat: implement slider and range-slider pointer events support

ed400ed


          fix: only handle pointer events on thumb or track parts

7b45a0a


          fix: improve logic for part detection and tests

345b724


          refactor: apply review suggestion

61a87f3


          test: merge assertions in change events tests

611cff6


          refactor: add listeners on the slider, test pointer capture

26295d3


          refactor: only use __thumbIndex for pointermove events

f69f2ae


          chore: add missing newline

d68d37f


          fix: get thumb index when clicking outside the track

9b8b175


          decompose __applyValue method

73f962c


          refactor: do not focus on mousedown on blank space

b3bf96f


          fix: only fire change event on track pointerup

de12d88


          Update packages/slider/test/slider.test.ts

a7ddf5f

Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>


          refactor: move mousedown listener to the mixin

b78feee


          fix: always use first or second thumb at the min or max

8e2cdb4


          fix: make value update logic work properly

24bb469

web-padawan force-pushed the feat/slider-pointer-events branch from 40c4621 to 24bb469 Compare

January 16, 2026 07:43

web-padawan added 3 commits

January 16, 2026 10:11


          fix: handle negative min value correctly

fff6a64


          fix: ignore pointerdown when right mouse button pressed

c023198


          chore: fix JSDoc comments

ac5b5f1

sonarqubecloud bot commented Jan 16, 2026

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

vursen approved these changes

View reviewed changes

web-padawan merged commit 5921415 into main

10 checks passed

web-padawan deleted the feat/slider-pointer-events branch

January 16, 2026 09:56

web-padawan mentioned this pull request

[Slider] Implement basic features #10948

Closed

8 tasks

vaadin-bot added the Released with Vaadin 25.1.0-beta1 label

Collaborator

vaadin-bot commented Mar 10, 2026

This ticket/PR has been released with Vaadin 25.1.0-beta1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Released with Vaadin 25.1.0-beta1