feat: add option to keep dialog within viewport when dragging#11030
Merged
sissbruecker merged 3 commits intomainfrom Jan 30, 2026
Merged
feat: add option to keep dialog within viewport when dragging#11030sissbruecker merged 3 commits intomainfrom
sissbruecker merged 3 commits intomainfrom
Conversation
DiegoCardoso
approved these changes
Jan 30, 2026
|
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
* feat: add option to keep dialog within viewport when dragging * add delta for assertions in Firefox * clarify that the property only affects dragging
sissbruecker
added a commit
that referenced
this pull request
Feb 6, 2026
#11076) * feat: add option to keep dialog within viewport when dragging * add delta for assertions in Firefox * clarify that the property only affects dragging Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
Collaborator
|
This ticket/PR has been released with Vaadin 25.1.0-beta1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
keepInViewportproperty that, when enabled, prevents dragging any of a dialog's edges outside of the viewport's bounds.Part of https://github.com/vaadin/sponsored-development/issues/36
Type of change