Skip to content

docs: add missing @fires and type for time-picker unparsable-change event #11300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
web-padawan merged 1 commit into from
Mar 10, 2026
+9 −0
Merged

docs: add missing @fires and type for time-picker unparsable-change event #11300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/time-picker/src/vaadin-time-picker.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,20 @@ export type TimePickerValueChangedEvent = CustomEvent<{ value: string }>;
*/
export type TimePickerValidatedEvent = CustomEvent<{ valid: boolean }>;

/**
* Fired when the user commits an unparsable value change and there is no change event.
*/
export type TimePickerUnparsableChangeEvent = CustomEvent;

export interface TimePickerCustomEventMap {
'invalid-changed': TimePickerInvalidChangedEvent;

'opened-changed': TimePickerOpenedChangedEvent;

'value-changed': TimePickerValueChangedEvent;

'unparsable-change': TimePickerUnparsableChangeEvent;

validated: TimePickerValidatedEvent;
}

Expand Down Expand Up @@ -130,6 +137,7 @@ export interface TimePickerEventMap extends HTMLElementEventMap, TimePickerCusto
* unparsable => unparsable | unparsable-change
*
* @fires {Event} change - Fired when the user commits a value change.
* @fires {Event} unparsable-change - Fired when the user commits an unparsable value change and there is no change event.
* @fires {CustomEvent} invalid-changed - Fired when the `invalid` property changes.
* @fires {CustomEvent} opened-changed - Fired when the `opened` property changes.
* @fires {CustomEvent} value-changed - Fired when the `value` property changes.
Expand Down
1 change: 1 addition & 0 deletions packages/time-picker/src/vaadin-time-picker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ import { TimePickerMixin } from './vaadin-time-picker-mixin.js';
* unparsable => unparsable | unparsable-change
*
* @fires {Event} change - Fired when the user commits a value change.
* @fires {Event} unparsable-change - Fired when the user commits an unparsable value change and there is no change event.
* @fires {CustomEvent} invalid-changed - Fired when the `invalid` property changes.
* @fires {CustomEvent} opened-changed - Fired when the `opened` property changes.
* @fires {CustomEvent} value-changed - Fired when the `value` property changes.
Expand Down