docs: add missing @fires annotations for message-input and context-menu#11303
Merged
sissbruecker merged 1 commit intomainfrom Mar 11, 2026
Merged
docs: add missing @fires annotations for message-input and context-menu#11303sissbruecker merged 1 commit intomainfrom
sissbruecker merged 1 commit intomainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
sissbruecker
approved these changes
Mar 11, 2026
Collaborator
|
This ticket/PR has been released with Vaadin 25.1.0-beta3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@fires {CustomEvent} submittovaadin-message-input.jsand.d.ts@fires {CustomEvent} close-all-menusand@fires {CustomEvent} items-outside-clicktovaadin-context-menu.jsand.d.tsTest plan
yarn release:cemand verify events have descriptions incustom-elements.jsonyarn lint:types🤖 Generated with Claude Code
Note
These events are present in corresponding TS event maps in
.d.tsbut are lacking JSDoc.