refactor: message attachment base styles and themes#11308
Merged
web-padawan merged 2 commits intomainfrom Mar 10, 2026
Merged
Conversation
tomivirkki
approved these changes
Mar 10, 2026
jouni
force-pushed
the
refactor/message-attachment-styles
branch
from
4af7781 to
b452e27
Compare
Member
Author
|
Removed the commented code (forgot to do that before pushing). |
web-padawan
reviewed
Mar 10, 2026
Member
web-padawan
left a comment
web-padawan
left a comment
There was a problem hiding this comment.
Let me add new custom CSS properties to the JSDoc for vaadin-message.
web-padawan
approved these changes
Mar 10, 2026
|
Collaborator
|
This ticket/PR has been released with Vaadin 25.1.0-beta3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix and clean up the base styles and themes for message attachments. Align the icon sizing with the sizing of the icon in upload-file thumbnail variant.
In Aura, it felt excessive to let the attachment buttons get all the same styles as vaadin-button.