fix: preserve active attribute on menu-bar button while submenu is open#11331
Merged
Conversation
…en (#11315) Override _setActive() in MenuBarButton to skip deactivation while the button has the expanded attribute, so the pressed visual state remains while the sub-menu is open. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
sissbruecker
approved these changes
Mar 12, 2026
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 12, 2026
…en (#11331) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
This ticket/PR has been released with Vaadin 25.1.0-beta3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_setActive()inMenuBarButtonto skip deactivation while the button has theexpandedattribute, preserving the pressed visual state while the sub-menu is openActiveMixinlisteners were removing theactiveattribute immediately after_setExpanded()set itFixes #11315
Test plan
activeattribute is preserved when opening submenu via Enter, Space, and clickactiveattribute is removed when submenu closes🤖 Generated with Claude Code