fix: postpone registration until first instance is created#11354
Merged
sissbruecker merged 3 commits intomainfrom Mar 13, 2026
Merged
fix: postpone registration until first instance is created#11354sissbruecker merged 3 commits intomainfrom
sissbruecker merged 3 commits intomainfrom
Conversation
web-padawan
changed the title
|
sissbruecker
approved these changes
Mar 13, 2026
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 13, 2026
* fix: postpone registtration until first instance is created * chore: remove protected finalize method from typings * test: ensure registrations is empty before element is created
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 13, 2026
* fix: postpone registtration until first instance is created * chore: remove protected finalize method from typings * test: ensure registrations is empty before element is created
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 13, 2026
* fix: postpone registtration until first instance is created * chore: remove protected finalize method from typings * test: ensure registrations is empty before element is created
sissbruecker
pushed a commit
that referenced
this pull request
Mar 13, 2026
…11355) * fix: postpone registtration until first instance is created * chore: remove protected finalize method from typings * test: ensure registrations is empty before element is created Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan
added a commit
that referenced
this pull request
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced usage of
finalize()method with a separate static method called from the constructor.Type of change