Skip to content

refactor!: rewrite master-detail-layout with CSS grid #11361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
web-padawan merged 38 commits into from
Mar 18, 2026

fix: expand master to fill layout when no detail with expand=detail

5673a69
Select commit
Loading
Failed to load commit list.
Merged

refactor!: rewrite master-detail-layout with CSS grid #11361

fix: expand master to fill layout when no detail with expand=detail
5673a69
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 18, 2026 in 1m 47s

Quality Gate passed

Issues
16 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 6 in packages/master-detail-layout/test/overflow.test.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=vaadin_web-components&issues=AZz3VA5UjZinLWc2dIur&open=AZz3VA5UjZinLWc2dIur&pullRequest=11361

Check warning on line 316 in packages/master-detail-layout/src/vaadin-master-detail-layout.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseFloat` over `parseFloat`. 

See more on https://sonarcloud.io/project/issues?id=vaadin_web-components&issues=AZz7iVN0tPc4Xpj8FGI8&open=AZz7iVN0tPc4Xpj8FGI8&pullRequest=11361

Check warning on line 280 in packages/master-detail-layout/src/vaadin-master-detail-layout.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=vaadin_web-components&issues=AZz7JE0qACzsL9rDLybu&open=AZz7JE0qACzsL9rDLybu&pullRequest=11361

Check warning on line 19 in packages/master-detail-layout/src/vaadin-master-detail-layout.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 

See more on https://sonarcloud.io/project/issues?id=vaadin_web-components&issues=AZz3VA6VjZinLWc2dIu3&open=AZz3VA6VjZinLWc2dIu3&pullRequest=11361

Check warning on line 22 in packages/master-detail-layout/src/vaadin-master-detail-layout.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseFloat` over `parseFloat`. 

See more on https://sonarcloud.io/project/issues?id=vaadin_web-components&issues=AZz3VA6VjZinLWc2dIu4&open=AZz3VA6VjZinLWc2dIu4&pullRequest=11361

Check warning on line 152 in packages/master-detail-layout/test/master-detail-layout.test.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseFloat` over `parseFloat`. 

See more on https://sonarcloud.io/project/issues?id=vaadin_web-components&issues=AZz3VA0djZinLWc2dIup&open=AZz3VA0djZinLWc2dIup&pullRequest=11361

Check warning on line 7 in packages/master-detail-layout/test/overflow.test.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=vaadin_web-components&issues=AZz3VA5UjZinLWc2dIus&open=AZz3VA5UjZinLWc2dIus&pullRequest=11361

Check warning on line 153 in packages/master-detail-layout/test/master-detail-layout.test.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `Number.parseFloat` over `parseFloat`. 

See more on https://sonarcloud.io/project/issues?id=vaadin_web-components&issues=AZz3VA0djZinLWc2dIuq&open=AZz3VA0djZinLWc2dIuq&pullRequest=11361

Check warning on line 8 in packages/master-detail-layout/test/overlay.test.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=vaadin_web-components&issues=AZz3VA5jjZinLWc2dIuz&open=AZz3VA5jjZinLWc2dIuz&pullRequest=11361

Check warning on line 7 in packages/master-detail-layout/test/overlay.test.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=vaadin_web-components&issues=AZz3VA5jjZinLWc2dIuy&open=AZz3VA5jjZinLWc2dIuy&pullRequest=11361

Check warning on line 8 in packages/master-detail-layout/test/split-mode.test.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=vaadin_web-components&issues=AZz3VA5bjZinLWc2dIuw&open=AZz3VA5bjZinLWc2dIuw&pullRequest=11361

Check warning on line 6 in packages/master-detail-layout/test/overlay.test.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=vaadin_web-components&issues=AZz3VA5jjZinLWc2dIux&open=AZz3VA5jjZinLWc2dIux&pullRequest=11361

Check warning on line 18 in packages/master-detail-layout/src/vaadin-master-detail-layout.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 

See more on https://sonarcloud.io/project/issues?id=vaadin_web-components&issues=AZz7iVN0tPc4Xpj8FGI6&open=AZz7iVN0tPc4Xpj8FGI6&pullRequest=11361

Check warning on line 7 in packages/master-detail-layout/test/split-mode.test.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=vaadin_web-components&issues=AZz3VA5bjZinLWc2dIuv&open=AZz3VA5bjZinLWc2dIuv&pullRequest=11361

Check warning on line 8 in packages/master-detail-layout/test/overflow.test.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=vaadin_web-components&issues=AZz3VA5UjZinLWc2dIut&open=AZz3VA5UjZinLWc2dIut&pullRequest=11361

Check warning on line 6 in packages/master-detail-layout/test/split-mode.test.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=vaadin_web-components&issues=AZz3VA5bjZinLWc2dIuu&open=AZz3VA5bjZinLWc2dIuu&pullRequest=11361
View more details on SonarQubeCloud