chore: resolve missing inherited members in CEM class declarations#11381
Merged
sissbruecker merged 1 commit intomainfrom Mar 23, 2026
Merged
chore: resolve missing inherited members in CEM class declarations#11381sissbruecker merged 1 commit intomainfrom
sissbruecker merged 1 commit intomainfrom
Conversation
The CEM analyzer only follows inheritedFrom one level deep, so members inherited through 2+ levels (e.g., EmailField → TextFieldMixin → FieldMixin → LabelMixin) are dropped from class declarations. Add a multi-pass resolution step in packageLinkPhase that copies missing members and attributes from mixin/superclass declarations to class declarations until the inheritance chain is fully resolved. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
2 tasks
sissbruecker
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inheritedFromone level deep, so members inherited through 2+ levels (e.g.,EmailField → TextFieldMixin → FieldMixin → LabelMixin) are dropped from class declarationspackageLinkPhasethat copies missing members and attributes from mixin/superclass declarations until the full inheritance chain is resolvedallDeclarationsmap once inpackageLinkPhaseso it can be reused by future pluginsTest plan
yarn release:cemand verify no errorspackages/text-field/custom-elements.json—TextFieldclass should havelabelmember and attributepackages/email-field/custom-elements.json—EmailFieldclass should havelabelmember and attributepackages/multi-select-combo-box/custom-elements.json—MultiSelectComboBoxshould haveaccessibleName,errorMessage,helperText,label🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com