chore: add multiple nested MDL dev page to use cases#11406
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
web-padawan
changed the title
jouni
reviewed
Mar 24, 2026
jouni
reviewed
Mar 24, 2026
Comment on lines
+173
to
+176
| <ul class="nav-list" id="appNav"> | ||
| <li data-key="home">Home</li> | ||
| <li data-key="manage" aria-current="page">Manage</li> | ||
| </ul> |
Member
There was a problem hiding this comment.
Any reason not to use <vaadin-side-nav>?
Member
Author
There was a problem hiding this comment.
I used it originally but then current attributes were messed up. Could add it back.
Member
There was a problem hiding this comment.
Not relevant on this test page, to use our side-nav component, if it’s cumbersome.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
jouni
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nav-section-list-detail.html) demonstrating 4 nested<vaadin-master-detail-layout>instances: App Nav → Section Nav → User List → User DetailTest plan
yarn startand navigate to/dev/mdl-use-cases/🤖 Generated with Claude Code