refactor: remove redundant replace grid-overlap rules in MDL#11409
Merged
web-padawan merged 1 commit intomainfrom Mar 25, 2026
Merged
refactor: remove redundant replace grid-overlap rules in MDL#11409web-padawan merged 1 commit intomainfrom
web-padawan merged 1 commit intomainfrom
Conversation
The detail-placeholder changes added explicit grid-row: 1 and grid-column: 1 to all detail elements in base rules, which already ensures #detail and #outgoing share the same grid cell. The replace-specific 1 / -1 span rules are no longer needed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
vursen
approved these changes
Mar 25, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grid-row: 1 / -1andgrid-column: 1 / -1rules from master-detail-layout base styles#detailand#outgoinginto the same grid cell during replace transitions (without explicit placement on the non-positioned axis, the second element was auto-placed into an implicit track)grid-row: 1/grid-column: 1to all detail elements in their base rules, making the replace-specific overrides redundantTest plan
yarn test --group master-detail-layout— all tests passyarn lint:css— pass🤖 Generated with Claude Code