Skip to content

fix: make conditional editing work with lazy columns (#11405) (CP: 25.1)#11410

Merged
sissbruecker merged 1 commit into
25.1from
cherry-pick-11405-to-25.1-1774431272111
Mar 25, 2026
Merged

fix: make conditional editing work with lazy columns (#11405) (CP: 25.1)#11410
sissbruecker merged 1 commit into
25.1from
cherry-pick-11405-to-25.1-1774431272111

Conversation

@vaadin-bot
Copy link
Copy Markdown
Collaborator

This PR cherry-picks changes from the original PR #11405 to branch 25.1.


Original PR description

Description

The conditional editing logic needs to access the row from a cell element and currently uses cell.parentElement. When using lazy column rendering, cells are created eagerly when rendering rows but are not added to the row yet, so accessing parentElement does not return the row reference.

This changes the logic to use the __parentRow property, which is set when creating the cell.

Fixes vaadin/flow-components#8976

Type of change

  • Bugfix

* fix: make conditional editing work with lazy columns

* fix tests

* handle cell editor navigation when using lazy column rendering

* make getEventContext work with lazily rendered cells

* stop editing when edited cell is scrolled out of view
@sonarqubecloud
Copy link
Copy Markdown

@sissbruecker sissbruecker merged commit 8ca950b into 25.1 Mar 25, 2026
10 checks passed
@sissbruecker sissbruecker deleted the cherry-pick-11405-to-25.1-1774431272111 branch March 25, 2026 09:49
@vaadin-bot
Copy link
Copy Markdown
Collaborator Author

This ticket/PR has been released with Vaadin 25.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants