fix: make conditional editing work with lazy columns (#11405) (CP: 25.0)#11411
Merged
sissbruecker merged 2 commits into25.0from Mar 25, 2026
Merged
fix: make conditional editing work with lazy columns (#11405) (CP: 25.0)#11411sissbruecker merged 2 commits into25.0from
sissbruecker merged 2 commits into25.0from
Conversation
* fix: make conditional editing work with lazy columns * fix tests * handle cell editor navigation when using lazy column rendering * make getEventContext work with lazily rendered cells * stop editing when edited cell is scrolled out of view
|
Comment on lines
+373
to
+377
| // Scroll column into view synchronously, which also triggers lazy column | ||
| // rendering to ensure cells for that column are in the DOM. | ||
| this._scrollHorizontallyToCell(column._headerCell); | ||
| this.__updateHorizontalScrollPosition(); | ||
| this.__updateColumnsBodyContentHidden(); |
Contributor
There was a problem hiding this comment.
scrollToColumn is not available in 25.0, so I replaced the call with what it essentially does in 25.1.
DiegoCardoso
approved these changes
Mar 25, 2026
Collaborator
Author
|
This ticket/PR has been released with Vaadin 25.0.8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks changes from the original PR #11405 to branch 25.0.
Original PR description