fix: use navbar-offset-size-bottom to set padding-bottom in app-layout in Aura#11425
Closed
DiegoCardoso wants to merge 1 commit intomainfrom
Closed
fix: use navbar-offset-size-bottom to set padding-bottom in app-layout in Aura#11425DiegoCardoso wants to merge 1 commit intomainfrom
padding-bottom in app-layout in Aura#11425DiegoCardoso wants to merge 1 commit intomainfrom
Conversation
As in Lumo and base style, use the calculated value from the `--_vaadin-app-layout-navbar-offset-size-bottom` CSS property to set the `padding-bottom` of the `app-layout` host element, to ensure that the content is not blocked by the bottom navbar in phone devices. Fix vaadin/flow-components#9038
|
Contributor
Author
|
Closing as the better solution would go by adding a new stylable area as decided here vaadin/flow-components#9038 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As in Lumo and base style, use the calculated value from the
--_vaadin-app-layout-navbar-offset-size-bottomCSS property to set thepadding-bottomof theapp-layouthost element, to ensure that the content is not blocked by the bottom navbar in phone devices.Fix vaadin/flow-components#9038
Type of change