test: restructure master-detail-layout DOM snapshot tests#11426
Merged
web-padawan merged 4 commits intomainfrom Mar 31, 2026
Merged
test: restructure master-detail-layout DOM snapshot tests#11426web-padawan merged 4 commits intomainfrom
web-padawan merged 4 commits intomainfrom
Conversation
Reorganize snapshot tests into focused sections (host, shadow, detail, detail placeholder) with proper overflow, hidden, and removed scenarios. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The has-detail attribute presence is already covered by DOM snapshot tests, making these explicit checks redundant. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
1 task
web-padawan
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
host,shadow,detail, anddetail placeholderoverflow,hidden, andremovedtest scenarios for detail and detail placeholderoverlay modetests with more granular detail-specific testshas-detailattribute presence (covered by snapshot tests)onceResizedconsistently instead ofnextFramefor reliable timingExtracted from #11403
Test plan
yarn test:snapshots --group master-detail-layout)yarn test --group master-detail-layout)🤖 Generated with Claude Code