fix(yamux): yamux uses wrong direction during dcutr#992
Closed
diegomrsantos wants to merge 5 commits intounstablefrom
Closed
fix(yamux): yamux uses wrong direction during dcutr#992diegomrsantos wants to merge 5 commits intounstablefrom
diegomrsantos wants to merge 5 commits intounstablefrom
Conversation
d1cba87 to
ce0685c
Compare
daaa99f to
3447baa
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #992 +/- ##
============================================
+ Coverage 83.23% 83.25% +0.01%
============================================
Files 91 91
Lines 15328 15331 +3
============================================
+ Hits 12759 12764 +5
+ Misses 2569 2567 -2
|
Contributor
Author
|
This is replaced by #994 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During DCUtR, the listener initiates the direct connection attempt and must connect to the other peer as the incoming upgrade direction. Yamux must use this direction to decide on using odd or even stream IDs, not the underlying connection direction -which in this case is TCP (or another transport) outgoing as the peer is initiating the connection.
This is an unusual case where a peer initiates a connection, but should treat it as incoming. The reason is probably that DCUtR happens when the other remote peer dials this peer relayed address, therefore the original connection was in fact incoming.
Related:
https://github.com/libp2p/specs/tree/master/yamux
https://github.com/libp2p/specs/blob/master/relay/DCUtR.md