Conversation
…ve SerializationVersion, require merge SerializationVersion and MessageMode together
…uced manual handling
…e-mode-and-remove-multi-message-id-flag
vinhtc27
changed the title
vinhtc27
changed the title
vinhtc27
changed the title
Benchmark for e625b3eClick to view benchmark
|
Benchmark for e625b3eClick to view benchmark
|
Benchmark for 88f5b5bClick to view benchmark
|
Benchmark for 88f5b5bClick to view benchmark
|
Benchmark for ac6b9ebClick to view benchmark
|
Benchmark for ac6b9ebClick to view benchmark
|
Benchmark for 3cb28fdClick to view benchmark
|
Benchmark for 3cb28fdClick to view benchmark
|
seemenkina
reviewed
Apr 28, 2026
| } | ||
|
|
||
| impl RLNWitnessInputSingle { | ||
| pub fn new( |
Collaborator
There was a problem hiding this comment.
don't forget to add validation of inputs into new functions
Contributor
Author
There was a problem hiding this comment.
I added it in the PR4, merge later to avoid conflict.
Comment on lines
+297
to
+298
| // TODO: new enum for partial witness instead of reusing SingleV1 version byte, which is technically not correct | ||
| // TODO: current master branch return SingleV1 or MultiV1 version byte based compile-time feature flag |
Collaborator
There was a problem hiding this comment.
I think this todo doesn't make sense in V3, right?
Contributor
Author
There was a problem hiding this comment.
Yes u right, the whole serialize format gonna change anyway
| } | ||
| } | ||
|
|
||
| pub struct RLNV3<Mode, ZkProof> { |
Collaborator
There was a problem hiding this comment.
So, I suppose here just part of the function that would be implemented, right?
Contributor
Author
There was a problem hiding this comment.
Yes this will be in PR4, its just all dummy methods for now, didnt cover all old public API yet
Benchmark for 6851d3dClick to view benchmark
|
Benchmark for 6851d3dClick to view benchmark
|
seemenkina
approved these changes
Apr 30, 2026
vinhtc27
deleted the
refactor/pr0-add-message-mode-and-remove-multi-message-id-flag
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: