Skip to content

Fix variable reassignment error#16

Merged
vadimdemedes merged 1 commit into
vadimdemedes:masterfrom
m-allanson:let-reassignment
Jun 20, 2019
Merged

Fix variable reassignment error#16
vadimdemedes merged 1 commit into
vadimdemedes:masterfrom
m-allanson:let-reassignment

Conversation

@m-allanson
Copy link
Copy Markdown
Contributor

Using variable reassignment in a component like this:

// in a component
let thing;
thing = "value";

was resulting in the following error from pastel dev:

✖ Build failed with the following error

TypeError: Cannot read property 'name' of undefined
    at AssignmentExpression (/Users/mike/d/my-test-cli/node_modules/pasteljs/lib/parse-command.js:263:25)
    at NodePath._call (/Users/mike/d/my-test-cli/node_modules/@babel/traverse/lib/path/context.js:53:20)
    at NodePath.call (/Users/mike/d/my-test-cli/node_modules/@babel/traverse/lib/path/context.js:40:17)
    at NodePath.visit (/Users/mike/d/my-test-cli/node_modules/@babel/traverse/lib/path/context.js:88:12)
    at TraversalContext.visitQueue (/Users/mike/d/my-test-cli/node_modules/@babel/traverse/lib/context.js:118:16)
    at TraversalContext.visitSingle (/Users/mike/d/my-test-cli/node_modules/@babel/traverse/lib/context.js:90:19)
    at TraversalContext.visit (/Users/mike/d/my-test-cli/node_modules/@babel/traverse/lib/context.js:146:19)
    at Function.traverse.node (/Users/mike/d/my-test-cli/node_modules/@babel/traverse/lib/index.js:94:17)
    at NodePath.visit (/Users/mike/d/my-test-cli/node_modules/@babel/traverse/lib/path/context.js:95:18)
    at TraversalContext.visitQueue (/Users/mike/d/my-test-cli/node_modules/@babel/traverse/lib/context.js:118:16)

This should fix it!

@vadimdemedes
Copy link
Copy Markdown
Owner

Nice fix, thank you!

@vadimdemedes vadimdemedes merged commit 0e959db into vadimdemedes:master Jun 20, 2019
@ukabu
Copy link
Copy Markdown

ukabu commented Dec 5, 2019

Did this commit made it into pastel 1.0.3?
I'm using 1.0.3 and get the same error.
In my package-lock.json

    "pastel": {
      "version": "1.0.3",
      "resolved": "https://registry.npmjs.org/pastel/-/pastel-1.0.3.tgz",
      "integrity": "sha512-Bq0WN/5RKikwc85DX4F0f3chJkhGvstmsA5ajToXDDI7BAx3ygO4rV/sUrNLFuac52kJpzLgWi8ctlwb9dwg2A==",
...

And in node_modules/pastel/lib/parse-command.js:260:50)

		AssignmentExpression({node}) {
			if (node.operator !== '=' || node.left.object.name !== componentName) {
				return;
			}

@ukabu
Copy link
Copy Markdown

ukabu commented Dec 5, 2019

Just saw that the merge was after the release of 1.0.3. Maybe releasing a 1.0.4 would be in order :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants