Skip to content

chore: Upgrade peer dependency ink#72

Merged
sindresorhus merged 7 commits into
vadimdemedes:mainfrom
jlarmstrongiv:main
Jun 6, 2024
Merged

chore: Upgrade peer dependency ink#72
sindresorhus merged 7 commits into
vadimdemedes:mainfrom
jlarmstrongiv:main

Conversation

@jlarmstrongiv
Copy link
Copy Markdown
Contributor

Closes #71

@jlarmstrongiv
Copy link
Copy Markdown
Contributor Author

I updated the PR to fix xo linting errors from updates to https://github.com/sindresorhus/eslint-plugin-unicorn 👍 triggering another workflow run would be great!

@sindresorhus
Copy link
Copy Markdown
Collaborator

CI is failing. Make sure npm test succeeds locally.

@jlarmstrongiv
Copy link
Copy Markdown
Contributor Author

jlarmstrongiv commented May 27, 2024

Not sure why, but I was only able to get ava to run tests by setting NODE_OPTIONS directly avajs/ava#2593 (comment)

Please try re-running the CI. While some tests were timing out due to my local environment, I am more confident the CI should pass.

@sindresorhus
Copy link
Copy Markdown
Collaborator

Ink 5 requires Node.js 18, so to support that, we also need to require it. Also update the Ink dev dependency so we can be sure it works.

@jlarmstrongiv
Copy link
Copy Markdown
Contributor Author

Alrighty, I originally thought it may be possible for pastel to support both ink v4 and v5, but I have changed it to require ink@5 and nodejs >=18 👍 tests still seem to pass, but you’ll need to run the workflow to confirm

Last but not least, as the minimum version of node has changed, I bumped pastel a major version to v3

@sindresorhus
Copy link
Copy Markdown
Collaborator

I bumped pastel a major version to v3

Don't make unrelated changes.

@sindresorhus sindresorhus merged commit c357d3d into vadimdemedes:main Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade ink to v5 compatible

2 participants