fix: german phone numbers by reverting #1391#1868
fix: german phone numbers by reverting #1391#1868profnandaa merged 2 commits intovalidatorjs:masterfrom
Conversation
| '015412345678', | ||
| ], | ||
| invalid: [ | ||
| '+4930405044550', |
There was a problem hiding this comment.
this is landline all +4930 are landlines. Mobile phone numbers must start with https://en.wikipedia.org/wiki/Telephone_numbers_in_Germany#Non-geographic_numbering must start with a 15, 16 or 17
| '17012345678', | ||
| '+4912345678910', | ||
| '+49015123456789', | ||
| '015345678910', |
There was a problem hiding this comment.
https://de.wikipedia.org/wiki/Vorwahl_01_(Deutschland)#015 153 and 154 are not valid numbers.
thomaschaaf
changed the title
tux-tn
left a comment
tux-tn
left a comment
There was a problem hiding this comment.
Thank you for your PR !
The regex LGTM, started commenting on #1391 suggesting you to open a PR but you were faster than me 😅
Can you just please change the PR title to a more meaningful message like fix(isMobilePhone): update regex to exclude landline numbers or anything better than just revert PR XXXX
tux-tn
added
🎉 first-pr
🧹 needs-update
tux-tn
left a comment
tux-tn
left a comment
There was a problem hiding this comment.
Never mind concerning PR title, you figured it out by yourself. Thank you again for your efforts 🎉
tux-tn
added
ready-to-land
Codecov Report
@@ Coverage Diff @@
## master #1868 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2059 2059
Branches 464 464
=========================================
Hits 2059 2059
Continue to review full report at Codecov.
|
3 participants
reverting #1391