Skip to content

add support for Gibraltar phone numbers#2232

Open
tsheaff wants to merge 1 commit intovalidatorjs:masterfrom
tsheaff:master
Open

add support for Gibraltar phone numbers#2232
tsheaff wants to merge 1 commit intovalidatorjs:masterfrom
tsheaff:master

Conversation

@tsheaff
Copy link

@tsheaff tsheaff commented Jun 7, 2023

Per the docs here, telephones in Gibraltar have CC +350 and are 8 digits long.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (9ba1735) to head (f5f6c6b).
⚠️ Report is 137 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2232   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         107      107           
  Lines        2405     2405           
  Branches      604      604           
=======================================
  Hits         2404     2404           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plaese Add tests, update readme and also mention the source

@rubiin rubiin added the ☹ abandoned PR that is unattended by the author for at least 3 months. label Jun 25, 2023
@pano9000
Copy link
Contributor

Thanks for the contribution, however your regex is too permissive, it allows way more than just mobile phone numbers - check the official ITU document here
https://www.itu.int/dms_pub/itu-t/oth/02/02/T02020000530007PDFE.pdf

However I am afraid this is has been abandoned completely, so marking it for deletion.

if nothing happens here in a week, I'd close this down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

☹ abandoned PR that is unattended by the author for at least 3 months. help needed marked-for-close needs-tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants