add support for Gibraltar phone numbers#2232
Open
tsheaff wants to merge 1 commit intovalidatorjs:masterfrom
Open
add support for Gibraltar phone numbers#2232tsheaff wants to merge 1 commit intovalidatorjs:masterfrom
tsheaff wants to merge 1 commit intovalidatorjs:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2232 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 107 107
Lines 2405 2405
Branches 604 604
=======================================
Hits 2404 2404
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rubiin
requested changes
Jun 12, 2023
Member
rubiin
left a comment
There was a problem hiding this comment.
Plaese Add tests, update readme and also mention the source
Contributor
|
Thanks for the contribution, however your regex is too permissive, it allows way more than just mobile phone numbers - check the official ITU document here However I am afraid this is has been abandoned completely, so marking it for deletion. if nothing happens here in a week, I'd close this down |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the docs here, telephones in Gibraltar have CC +350 and are 8 digits long.
Checklist