Document server_name, valkey_version, and redis_version INFO fields#427
Open
kovan wants to merge 3 commits intovalkey-io:mainfrom
Open
Document server_name, valkey_version, and redis_version INFO fields#427kovan wants to merge 3 commits intovalkey-io:mainfrom
kovan wants to merge 3 commits intovalkey-io:mainfrom
Conversation
Document how Valkey maintains backward compatibility with Redis OSS: 1. Version compatibility: forked from Redis 7.2.4, compatible with all Redis OSS versions up to 7.2.x, not compatible with Redis CE 7.4+ 2. INFO fields: redis_version is fixed at 7.2.4 for client compatibility, server_version reports the actual Valkey version 3. Lua scripting: both redis.call() and server.call() namespaces work 4. Module API: both RedisModule_* and ValkeyModule_* prefixes are supported All information verified against the Valkey source code (version.h, redismodule.h, valkeymodule.h). Fixes valkey-io#14
- Add server_name field description (was in example output but not in the field descriptions list) - Expand redis_version description to clarify it is fixed at 7.2.4 and does not change across Valkey releases - Expand valkey_version description to clarify it is the actual version to check Fixes valkey-io#15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
server_nameto the server section field descriptions (it was in the example output but missing from the descriptions list)redis_versiondescription to clarify it is fixed at 7.2.4 across all Valkey releases for client compatibilityvalkey_versiondescription to recommend using it instead ofredis_versionVerified against
src/version.hand the PRs referenced in the issue (valkey-io/valkey#232, valkey-io/valkey#47).Fixes #15