feat: Use valkey-bundle docker images for modules related test (9.0+)#242
Open
edlng wants to merge 7 commits intovalkey-io:mainfrom
Open
feat: Use valkey-bundle docker images for modules related test (9.0+)#242edlng wants to merge 7 commits intovalkey-io:mainfrom
edlng wants to merge 7 commits intovalkey-io:mainfrom
Conversation
Signed-off-by: Edward Liang <edward.liang@improving.com>
Signed-off-by: Edward Liang <edward.liang@improving.com>
Signed-off-by: Edward Liang <edward.liang@improving.com>
Signed-off-by: Edward Liang <edward.liang@improving.com>
Signed-off-by: Edward Liang <edward.liang@improving.com>
Signed-off-by: Edward Liang <edward.liang@improving.com>
Signed-off-by: Edward Liang <edward.liang@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Docker-based valkey-bundle servers on dedicated ports for module tests (Search, JSON, Bloom, LDAP). Regular tests still run against the source-built server.
On the 9.0 / ubuntu matrix, CI now builds from source (like every other combo) AND pulls the
valkey/valkey-bundleDocker image. The source-built server handles all existing tests. The Docker containers run on separate ports (standalone: 6389, cluster: 8001-8006) with modules loaded, and exportmodules-standalone-endpoint/modules-cluster-endpointsenv vars for module-specific tests to pick up.We tried routing everything through Docker first, but the bundle image is pinned to
9.1-rc1(no stable 9.0 tag yet) and that caused consistent standalone timeouts. Separate ports and separate servers to handle module-related tests should be sufficient and better.Issue link
Closes #245
What changed
.github/workflows/start-valkey-docker/action.yml. Pullsvalkey/valkey-bundle:9.1-rc1, starts standalone (port 6389) and cluster (ports 8001-8006) containers with--network host, forms the cluster, writes endpoint env vars. Uses the source-builtvalkey-clialready on the host, so no binary extraction needed.install-shared-dependenciesnow always builds from source first. For 9.0 on ubuntu it also runs the Docker action afterward.Limitations
9.1-rc1pin means module tests hit a pre-release server . TODO in the action to swap once stable tags exist.modules-*env vars yet. feat: Add Valkey Search Support #225.Testing
Ran the 9.0 / ubuntu matrix three times. Regular tests pass on the source-built server. Docker containers start and respond to PING. TLS tests work via
cluster_manager.py+ source-builtvalkey-server. Confirmed ports 6389 and 8001-8006 don't collide with anything in the test suite orcluster_manager.py's random port range.Checklist
CHANGELOG.md,README.md,DEVELOPER.md, and other documentation files are updated.mainor releasemain, squash otherwise.