Merged
Conversation
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Java: Add Logger
Yury-Fridlyand
requested review from
Yury-Fridlyand,
aaron-congo,
acarbonetto,
barshaul and
shohamazon
Contributor
Author
|
Panic handling is coming in a separate PR that overhauls how we handle errors in the FFI layer in general. |
Collaborator
|
@jonathanl-bq Ping me when it's ready |
Collaborator
The panic handling changes got merged already: |
jduo
reviewed
Jun 30, 2024
Yury-Fridlyand
left a comment
Yury-Fridlyand
left a comment
There was a problem hiding this comment.
More logging todos were merged today, sorry.
Please see MessageHandler and #1662
|
@barshaul round |
Yury-Fridlyand
approved these changes
Jul 1, 2024
java/client/src/main/java/glide/connectors/handlers/MessageHandler.java
Outdated
Show resolved
Hide resolved
…dler.java Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
acarbonetto
approved these changes
Jul 1, 2024
| @Getter private static Level loggerLevel; | ||
|
|
||
| private static void initLogger(@NonNull Level level, String fileName) { | ||
| if (level == Level.DISABLED) { |
Contributor
There was a problem hiding this comment.
DISABLED option was added to Java side for testing, since we don't want to log when we have mocks. There's other ways to do it (mocking static objects is annoying, but possible), but this is the best way.
| @BeforeEach | ||
| @SneakyThrows | ||
| public void createTestClient() { | ||
| Logger.setLoggerConfig(Logger.Level.DISABLED); |
Contributor
There was a problem hiding this comment.
Right - this is why we need a DISABLED level logger.
Can we add a TODO to add this level to the redis-core side?
jduo
reviewed
Jul 1, 2024
java/client/src/main/java/glide/connectors/handlers/MessageHandler.java
Outdated
Show resolved
Hide resolved
jduo
reviewed
Jul 1, 2024
java/client/src/main/java/glide/connectors/handlers/MessageHandler.java
Outdated
Show resolved
Hide resolved
jduo
approved these changes
Jul 2, 2024
barshaul
approved these changes
Jul 2, 2024
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jul 16, 2024
* Implement Logger for Java client Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Yury-Fridlyand
added a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 6, 2025
* Implement Logger for Java client Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
The Logger implementation here is based on the Python client's implementation, with some relatively small Java/JNI specific changes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.