Feature/sortby implementation#618
Merged
allenss-amazon merged 27 commits intovalkey-io:mainfrom Feb 11, 2026
Merged
Conversation
AlexFilipImproving
force-pushed
the
feature/sortby-implementation
branch
from
3a35723 to
645bb26
Compare
Comment on lines
40
to
44
| // By default, FT.SEARCH does not require complete results and can optimized | ||
| // with LIMIT based trimming. | ||
| // TODO: When SORTBY or similar clauses are supported, implement the correct | ||
| // logic here to return true when those clauses are present. | ||
| bool RequiresCompleteResults() const override { return false; } |
Member
There was a problem hiding this comment.
Can we ensure that each Search Operation (SEARCH / AGGREGATE) correctly reports if it needs complete results or not? If sorting is needed, this API needs to reflect it
Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
AlexFilipImproving
force-pushed
the
feature/sortby-implementation
branch
from
8defc22 to
62f13e1
Compare
Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
Member
|
Can we add SORTBY and LIMIT integration tests to TestNonVector? |
Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
…valkey-search into feature/sortby-implementation
Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
AlexFilipImproving
force-pushed
the
feature/sortby-implementation
branch
from
4967cc2 to
20106f2
Compare
Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
allenss-amazon
approved these changes
Feb 11, 2026
boda26
pushed a commit
to boda26/valkey-search
that referenced
this pull request
Feb 12, 2026
Implementation of `SORTBY` on `FT.SEARCH` Please check the conversation in Bit-Quill#1 first --------- Signed-off-by: Alexandru Filip <alexandru.filip@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of
SORTBYonFT.SEARCHPlease check the conversation in Bit-Quill#1 first