Implement memory reservation on ingestion#884
Open
allenss-amazon wants to merge 1 commit intovalkey-io:mainfrom
Open
Implement memory reservation on ingestion#884allenss-amazon wants to merge 1 commit intovalkey-io:mainfrom
allenss-amazon wants to merge 1 commit intovalkey-io:mainfrom
Conversation
Signed-off-by: Allen Samuels <allenss@amazon.com>
| *max_nonvector_search_results_fetched); | ||
| } | ||
|
|
||
| /// Register the "--mutation-weight-vector" flag. Controls the weight multiplier |
Member
There was a problem hiding this comment.
Do we want these to be App or Dev configs?
Member
There was a problem hiding this comment.
IMO, we can mark all of these as Dev configs for now
| itr->second.from_backfill = from_backfill; | ||
| itr->second.from_multi = from_multi; | ||
| itr->second.sequence_number = sequence_number; | ||
| itr->second.weighted_buffer.resize( |
Member
There was a problem hiding this comment.
Can we add documentation on weighted_buffer explaining what this helps us solve?
Member
Author
There was a problem hiding this comment.
Let's see if this resolves the problem. If it does we can clean this up.
Comment on lines
+1769
to
+1770
| if (attr_itr != attributes_.end()) { | ||
| switch (attr_itr->second.GetIndex()->GetIndexerType()) { |
Member
There was a problem hiding this comment.
Can each Attribute type instead implement a Weight function where we just return the weight of the config? It will help avoid this switch statement / case handling here
Member
Author
There was a problem hiding this comment.
Yes. A virtual function would have been a better choice.
KarthikSubbarao
added a commit
that referenced
this pull request
Mar 27, 2026
Add memory reservation based on mutation queue This is picking up the change from here: #884 by @allenss-amazon --------- Signed-off-by: Allen Samuels <allenss@amazon.com> Signed-off-by: KarthikSubbarao <karthikrs2021@gmail.com> Co-authored-by: Allen Samuels <allenss@amazon.com>
rileydes-improving
pushed a commit
to Bit-Quill/valkey-search
that referenced
this pull request
Apr 1, 2026
Add memory reservation based on mutation queue This is picking up the change from here: valkey-io#884 by @allenss-amazon --------- Signed-off-by: Allen Samuels <allenss@amazon.com> Signed-off-by: KarthikSubbarao <karthikrs2021@gmail.com> Co-authored-by: Allen Samuels <allenss@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.