Skip to content

Implement configuration for TAG wildcard minimum prefix length#896

Merged
KarthikSubbarao merged 1 commit intovalkey-io:mainfrom
bandalgomsu:gh-895
Mar 16, 2026
Merged

Implement configuration for TAG wildcard minimum prefix length#896
KarthikSubbarao merged 1 commit intovalkey-io:mainfrom
bandalgomsu:gh-895

Conversation

@bandalgomsu
Copy link
Copy Markdown
Contributor

kDefaultMinPrefixLength is annotated as “configurable”, but it is currently hardcoded and cannot be changed at runtime.
This PR adds a module config (search.tag-min-prefix-length) to control the minimum prefix length for TAG wildcard queries (e.g., @field:{prefix*}).

issue : #895

Signed-off-by: Su Ko <rhtn1128@gmail.com>
Copy link
Copy Markdown
Member

@allenss-amazon allenss-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming that the regression tests pass.

@KarthikSubbarao KarthikSubbarao merged commit 1045bb0 into valkey-io:main Mar 16, 2026
9 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in Valkey-search 1.2 Mar 16, 2026
rileydes-improving pushed a commit to Bit-Quill/valkey-search that referenced this pull request Mar 16, 2026
…y-io#896)

kDefaultMinPrefixLength is annotated as “configurable”, but it is
currently hardcoded and cannot be changed at runtime.
This PR adds a module config (search.tag-min-prefix-length) to control
the minimum prefix length for TAG wildcard queries (e.g.,
@field:{prefix*}).

issue : valkey-io#895

Signed-off-by: Su Ko <rhtn1128@gmail.com>
rileydes-improving pushed a commit to Bit-Quill/valkey-search that referenced this pull request Mar 16, 2026
…y-io#896)

kDefaultMinPrefixLength is annotated as “configurable”, but it is
currently hardcoded and cannot be changed at runtime.
This PR adds a module config (search.tag-min-prefix-length) to control
the minimum prefix length for TAG wildcard queries (e.g.,
@field:{prefix*}).

issue : valkey-io#895

Signed-off-by: Su Ko <rhtn1128@gmail.com>
rileydes-improving pushed a commit to Bit-Quill/valkey-search that referenced this pull request Mar 16, 2026
…y-io#896)

kDefaultMinPrefixLength is annotated as “configurable”, but it is
currently hardcoded and cannot be changed at runtime.
This PR adds a module config (search.tag-min-prefix-length) to control
the minimum prefix length for TAG wildcard queries (e.g.,
@field:{prefix*}).

issue : valkey-io#895

Signed-off-by: Su Ko <rhtn1128@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.2-ga-blocker Blocker for 1.2 GA

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants