Deflake MRMWMutexTest.VerifyMayProlong test#928
Closed
Aksha1812 wants to merge 3 commits intovalkey-io:mainfrom
Closed
Deflake MRMWMutexTest.VerifyMayProlong test#928Aksha1812 wants to merge 3 commits intovalkey-io:mainfrom
Aksha1812 wants to merge 3 commits intovalkey-io:mainfrom
Conversation
Signed-off-by: Aksha Thakkar <thaakb@amazon.com>
Aksha1812
force-pushed
the
fulltext-dev-aksha27
branch
from
11d8785 to
5366972
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prolonged reader was releasing its lock before all read tasks finished and only waiting until the duration of the sleep, letting the writer sneak in and set run_write=true.
Fixed by waiting for read_tasks_completed_notification inside the lock scope, so the reader holds the lock until all reads are done.