Open
Conversation
Signed-off-by: Su Ko <rhtn1128@gmail.com>
docs/commands/ft.aggregate.md
Outdated
| keys are loaded. The key itself can be loaded by specifying `@__key`. For vector queries, the distance can also be loaded by using the name of that field. | ||
| - `SLOP <slop>` (Optional): Specifies a slop value for proximity matching of terms. | ||
| - `TIMEOUT <timeout>` (optional): Lets you set a timeout value for the search command. This must be an integer in milliseconds. | ||
| - `TIMEOUT <timeout>` (optional): Lets you set a timeout value for the search command. This must be an integer in milliseconds. If an index was created with `SEARCH_TIMEOUT`, this query-level `TIMEOUT` value takes precedence. |
Member
There was a problem hiding this comment.
Maybe say that this "If present, overrides the default TIMEOUT value. The default timeout can be specified by the SEARCH_TIMEOUT option for this index or the global search.default-timeout-ms configuration value.
docs/commands/ft.create.md
Outdated
|
|
||
| - `SKIPINITIALSCAN` (optional): If specified, this option skips the normal backfill operation for an index. If this option is specified, pre-existing keys which match the `PREFIX` clause will not be loaded into the index during a backfill operation. This clause has no effect on processing of key mutations _after_ an index is created, i.e., keys which are mutated after an index is created and satisfy the data type and `PREFIX` clause will be inserted into that index. | ||
|
|
||
| - `SEARCH_TIMEOUT <timeout>` (optional): Sets the default timeout in milliseconds for `FT.SEARCH` and `FT.AGGREGATE` requests on this index. A query-level `TIMEOUT` argument overrides this value. |
Member
There was a problem hiding this comment.
I think search_timeout is misleading because it applies to both ft.search and ft.aggregate. Perhaps QUERY_TIMEOUT ?
docs/commands/ft.search.md
Outdated
| - `SOMESHARDS` (Optional): If specified, the command will generate a best-effort reply if all shards have not responded within the timeout interval. | ||
| - `SORTBY <field> [ASC | DESC]` (Optional): If present, results are sorted according the value of the specified field and the optional sort-direction instruction. By default, vector results are sorted in distance order and non-vector results are not sorted in any particular order. Sorting is applied before the `LIMIT` clause is applied. | ||
| - `TIMEOUT <timeout>` (optional): Lets you set a timeout value for the search command. This must be an integer in milliseconds. | ||
| - `TIMEOUT <timeout>` (optional): Lets you set a timeout value for the search command. This must be an integer in milliseconds. If an index was created with `SEARCH_TIMEOUT`, this query-level `TIMEOUT` value takes precedence. |
Member
There was a problem hiding this comment.
Should be same as ft.aggregate language.
integration/test_cancel.py
Outdated
| "Pausepoint search_entries_fetcher was not hit" | ||
|
|
||
| # Hold the query at pausepoint long enough to exceed index timeout. | ||
| time.sleep(0.2) |
Member
There was a problem hiding this comment.
Why is there a sleep here? Can't there be something specific to wait for? Timed sleeps almost always create flaky tests.
src/commands/commands.cc
Outdated
| parameters->index_schema, | ||
| schema_manager.GetIndexSchema(db_num, parameters->index_schema_name)); | ||
| parameters->timeout_ms = | ||
| parameters->index_schema->GetSearchTimeoutMs() > 0 |
Member
There was a problem hiding this comment.
This code precludes setting a timeout value to 0, which is a potential future compatibility issue. Why not set the default value before the command is parsed?
src/index_schema.proto
Outdated
| repeated string stop_words = 11; | ||
| uint32 min_stem_size = 12; | ||
| bool skip_initial_scan = 13; | ||
| uint32 search_timeout_ms = 14; |
Member
There was a problem hiding this comment.
I think this should be optional, just like std::option so that if it's not specified, then the current global default is used.
testing/ft_create_parser_test.cc
Outdated
| absl::string_view score_field; | ||
| absl::string_view payload_field; | ||
| bool skip_initial_scan{false}; | ||
| uint32_t search_timeout_ms{0}; |
Member
There was a problem hiding this comment.
This should be std::optional
src/index_schema.h
Outdated
| uint64_t fingerprint_{0}; | ||
| uint32_t version_{0}; | ||
| bool skip_initial_scan_{false}; | ||
| uint32_t search_timeout_ms_{0}; |
Signed-off-by: Su Ko <rhtn1128@gmail.com>
Signed-off-by: Su Ko <rhtn1128@gmail.com>
Signed-off-by: Su Ko <rhtn1128@gmail.com>
Signed-off-by: Su Ko <rhtn1128@gmail.com>
Signed-off-by: Su Ko <rhtn1128@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement default search timeout per index and setting default search timeout in FT.CREATE
in FT.SEARCH or FT.AGGREGATE, timeout is applied in the following order of priority
issue : #383