Rewrite header parsing to improve spec compliance#2030
Merged
erikdubbelboer merged 1 commit intomasterfrom Aug 12, 2025
Merged
Conversation
erikdubbelboer
force-pushed
the
deprecated-newline-separator
branch
from
6733621 to
e5b271d
Compare
erikdubbelboer
force-pushed
the
http-header-parser
branch
from
2f9e7db to
0d3e7a8
Compare
erikdubbelboer
changed the base branch from
deprecated-newline-separator
to
master
erikdubbelboer
force-pushed
the
http-header-parser
branch
from
0d3e7a8 to
2ee332b
Compare
This change updates header parsing to match the behavior of net/http more closely. **Breaking change**: headers delimited by `\n` (instead of `\r\n`) are no longer supported. Previously, fasthttp accepted `\n` as a delimiter, which is not spec compliant. This made it difficult to correctly parse headers containing both `\n` and `\r\n`.
erikdubbelboer
force-pushed
the
http-header-parser
branch
from
2ee332b to
9b6d694
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates header parsing to match the behavior of net/http more closely.
Breaking change: headers delimited by
\n(instead of\r\n) are no longer supported.Previously, fasthttp accepted
\nas a delimiter, which is not spec compliant. This made it difficult to correctly parse headers containing both\nand\r\n.Benchmarks show that the new parser is slightly slower, but still a lot faster than net/http.
TODO: After merged add fuzz tests to: https://github.com/google/oss-fuzz/blob/20a387d78148c14dd5243ea1b16164fe08b73884/projects/fasthttp/build.sh
Fixes: #2020
Fixes: #1974